Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsoundness in FdSet methods #1575

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

taylordotfish
Copy link
Contributor

Ensure file descriptors are nonnegative and less than FD_SETSIZE. (Fixes #1572.)

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would you mind please adding a CHANGELOG entry and maybe a unit test?

@asomers asomers added this to the 0.23.1 milestone Oct 19, 2021
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would you please squash your commits next?

@asomers
Copy link
Member

asomers commented Oct 22, 2021

I'm afraid you'll have to rebase to fix the test failures.

Ensure file descriptors are nonnegative and less than `FD_SETSIZE`.
(Fixes nix-rust#1572.)
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors bors bot merged commit 3429165 into nix-rust:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsoundness in FdSet
2 participants